[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

[Matthias Braun via llvm-commits]

MatzeB added a comment.

What about changing `isSubregFoldable()` to not take any parameters and just return true/false, so all the decision logic can stay in `foldMemoryOperand()`? At least that keeps the newly added API as simple as possible.
It also seems to match the usage pattern in https://reviews.llvm.org/D27002.



================
Comment at: lib/CodeGen/TargetInstrInfo.cpp:574
   // Straight COPY may fold as load/store.
   if (!MI.isCopy() || Ops.size() != 1)
     return nullptr;
----------------
 (can't remove this comment because of phabricator bug http://llvm.org/PR30572)


https://reviews.llvm.org/D26521