[PATCH] D26948: TargetSubtargetInfo: Move implementation to lib/CodeGen; NFC

[Matthias Braun via llvm-commits]

I cannot see a single method in that class that I would not consider related to CodeGen; the only exception seems to be the constructor (arguments) to me.
And well the implementation of the constructor does nothing except forwarding all those arguments to MCSubtargetInfo. So we already have our divide from CodeGen by way of MCSubtargetInfo and there is nothing else left to divide/adapt.

I also found out that the createMachineScheduler() function I wanted to add already existed in TargetPassConfig, so I don't need this patch anymore to continue. We may or may not apply it anyway.

- Matthias

> On Nov 22, 2016, at 9:42 AM, Eric Christopher via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> I'd almost rather see an adapter for the various codegen style things implemented rather than moving TargetSubtargetInfo.
> 
> -eric
> 
> On Mon, Nov 21, 2016 at 6:24 PM Chandler Carruth <chandlerc at gmail.com <mailto:chandlerc at gmail.com>> wrote:
> chandlerc accepted this revision.
> chandlerc added a comment.
> This revision is now accepted and ready to land.
> 
> Sure. What's one more.
> 
> 
> Repository:
>   rL LLVM
> 
> https://reviews.llvm.org/D26948 <https://reviews.llvm.org/D26948>
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/acbda4ea/attachment.html>