<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">I cannot see a single method in that class that I would not consider related to CodeGen; the only exception seems to be the constructor (arguments) to me.</div><div class="">And well the implementation of the constructor does nothing except forwarding all those arguments to MCSubtargetInfo. So we already have our divide from CodeGen by way of MCSubtargetInfo and there is nothing else left to divide/adapt.</div><div class=""><br class=""></div><div class="">I also found out that the createMachineScheduler() function I wanted to add already existed in TargetPassConfig, so I don't need this patch anymore to continue. We may or may not apply it anyway.</div><div class=""><br class=""></div><div class="">- Matthias</div><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 22, 2016, at 9:42 AM, Eric Christopher via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'd almost rather see an adapter for the various codegen style things implemented rather than moving TargetSubtargetInfo.<div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Nov 21, 2016 at 6:24 PM Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">chandlerc accepted this revision.<br class="gmail_msg">
chandlerc added a comment.<br class="gmail_msg">
This revision is now accepted and ready to land.<br class="gmail_msg">
<br class="gmail_msg">
Sure. What's one more.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D26948" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26948</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>