[PATCH] D26961: [mips] seb, seh instruction aliases

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 11:02:51 PST 2016


sdardis marked an inline comment as done.
sdardis added inline comments.


================
Comment at: lib/Target/Mips/MicroMipsInstrInfo.td:1186-1189
+  def : MipsInstAlias<"seh $rd", (SEH_MM GPR32Opnd:$rd, GPR32Opnd:$rd), 0>,
+                     ISA_MIPS1_NOT_32R6_64R6;
+  def : MipsInstAlias<"seb $rd", (SEB_MM GPR32Opnd:$rd, GPR32Opnd:$rd), 0>,
+                     ISA_MIPS1_NOT_32R6_64R6;
----------------
vkalintiris wrote:
> Shouldn't we use ISA_MIPS32R2_NOT_32R6_64R6 instead of ISA_MIPS1_NOT_32R6_64R6?
Yeah, I'd missed that predicate during development.


Repository:
  rL LLVM

https://reviews.llvm.org/D26961





More information about the llvm-commits mailing list