[PATCH] D26961: [mips] seb, seh instruction aliases

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 10:22:40 PST 2016


vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.

LGTM. I have one question/suggestion inline.



================
Comment at: lib/Target/Mips/MicroMipsInstrInfo.td:1186-1189
+  def : MipsInstAlias<"seh $rd", (SEH_MM GPR32Opnd:$rd, GPR32Opnd:$rd), 0>,
+                     ISA_MIPS1_NOT_32R6_64R6;
+  def : MipsInstAlias<"seb $rd", (SEB_MM GPR32Opnd:$rd, GPR32Opnd:$rd), 0>,
+                     ISA_MIPS1_NOT_32R6_64R6;
----------------
Shouldn't we use ISA_MIPS32R2_NOT_32R6_64R6 instead of ISA_MIPS1_NOT_32R6_64R6?


Repository:
  rL LLVM

https://reviews.llvm.org/D26961





More information about the llvm-commits mailing list