[PATCH] D26851: [SelectionDAG] ComputeNumSignBits of TRUNCATE operations

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 13:50:34 PST 2016


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2833
+    if (Tmp2 > (Tmp - VTBits))
+      return Tmp2 - (Tmp - VTBits);
     break;
----------------
efriedma wrote:
> Please use variable names which are not "Tmp" and "Tmp2".
No problem - but these are the default variables that are already used in most of the other cases.


Repository:
  rL LLVM

https://reviews.llvm.org/D26851





More information about the llvm-commits mailing list