[PATCH] D26851: [SelectionDAG] ComputeNumSignBits of TRUNCATE operations

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 09:59:30 PST 2016


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2833
+    if (Tmp2 > (Tmp - VTBits))
+      return Tmp2 - (Tmp - VTBits);
     break;
----------------
Please use variable names which are not "Tmp" and "Tmp2".


Repository:
  rL LLVM

https://reviews.llvm.org/D26851





More information about the llvm-commits mailing list