[PATCH] D26130: [ELF] - Implemented --symbol-ordering-file option.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 10:24:26 PST 2016


Well, if I knew it was a completely new feature, I didn't LGTM on this
patch. It needs a strong justification to add a new feature, and even if we
agree with a need of a feature, we still have to discuss what is the best
way of doing it. I think if gold already has a similar feature, we should
implement that, instead of inventing our own.

We probably should revert this now, and restart from a proposal and
discussion.

On Fri, Nov 18, 2016 at 11:15 PM, George Rimar <grimar at accesssoftek.com>
wrote:

> >Until now, I was thinking that --symbol-ordering-file is a feature that
> ld.gold has, but looks like ld.gold doesn't have one. gold has
> --section-ordering-file instead. >Where does this --symbol-ordering-file
> feature come from?
>
>
> Yes, that is true. Reason to do that was that symbol ordering file allows
>
> to map symbols to sections with the same name like .text and reorder them.
> Sections ordering file does not allow to
>
> do that.
>
>
> George.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161119/585766a2/attachment.html>


More information about the llvm-commits mailing list