[llvm] r286962 - Get GlobalISel to build on Linux after r286407

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 04:55:31 PST 2016


Hi Ahmed,

Makes sense. Thanks!

Diana

On 17 November 2016 at 00:36, Ahmed Bougacha <ahmed.bougacha at gmail.com>
wrote:

> Hi Diana,
>
> I moved addLandingPadInfo to CodeGen and reverted this in r287168:
> it's important that GlobalISel not depend on SelectionDAG at all, as
> it's intended to be usable without it.  Let me know if there's still a
> problem.
>
> -Ahmed
>
>
> On Tue, Nov 15, 2016 at 6:11 AM, Diana Picus via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: rovka
> > Date: Tue Nov 15 08:11:11 2016
> > New Revision: 286962
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=286962&view=rev
> > Log:
> > Get GlobalISel to build on Linux after r286407
> >
> > r286407 has introduced calls to llvm::AddLandingPadInfo, which lives in
> the
> > SelectionDAG component. Add it to LLVMBuild to avoid linker failures on
> Linux.
> >
> > Modified:
> >     llvm/trunk/lib/CodeGen/GlobalISel/LLVMBuild.txt
> >
> > Modified: llvm/trunk/lib/CodeGen/GlobalISel/LLVMBuild.txt
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> CodeGen/GlobalISel/LLVMBuild.txt?rev=286962&r1=286961&r2=286962&view=diff
> > ============================================================
> ==================
> > --- llvm/trunk/lib/CodeGen/GlobalISel/LLVMBuild.txt (original)
> > +++ llvm/trunk/lib/CodeGen/GlobalISel/LLVMBuild.txt Tue Nov 15 08:11:11
> 2016
> > @@ -19,4 +19,4 @@
> >  type = Library
> >  name = GlobalISel
> >  parent = CodeGen
> > -required_libraries = Analysis CodeGen Core MC Support Target
> TransformUtils
> > +required_libraries = Analysis CodeGen Core MC SelectionDAG Support
> Target TransformUtils
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161117/8beaa77e/attachment.html>


More information about the llvm-commits mailing list