<div dir="ltr">Hi Ahmed,<div><br></div><div>Makes sense. Thanks!</div><div><br></div><div>Diana</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 17 November 2016 at 00:36, Ahmed Bougacha <span dir="ltr"><<a href="mailto:ahmed.bougacha@gmail.com" target="_blank">ahmed.bougacha@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Diana,<br>
<br>
I moved addLandingPadInfo to CodeGen and reverted this in r287168:<br>
it's important that GlobalISel not depend on SelectionDAG at all, as<br>
it's intended to be usable without it.  Let me know if there's still a<br>
problem.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Ahmed<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, Nov 15, 2016 at 6:11 AM, Diana Picus via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: rovka<br>
> Date: Tue Nov 15 08:11:11 2016<br>
> New Revision: 286962<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=286962&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=286962&view=rev</a><br>
> Log:<br>
> Get GlobalISel to build on Linux after r286407<br>
><br>
> r286407 has introduced calls to llvm::AddLandingPadInfo, which lives in the<br>
> SelectionDAG component. Add it to LLVMBuild to avoid linker failures on Linux.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/CodeGen/<wbr>GlobalISel/LLVMBuild.txt<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/<wbr>GlobalISel/LLVMBuild.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/LLVMBuild.txt?rev=286962&r1=286961&r2=286962&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>CodeGen/GlobalISel/LLVMBuild.<wbr>txt?rev=286962&r1=286961&r2=<wbr>286962&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/CodeGen/<wbr>GlobalISel/LLVMBuild.txt (original)<br>
> +++ llvm/trunk/lib/CodeGen/<wbr>GlobalISel/LLVMBuild.txt Tue Nov 15 08:11:11 2016<br>
> @@ -19,4 +19,4 @@<br>
>  type = Library<br>
>  name = GlobalISel<br>
>  parent = CodeGen<br>
> -required_libraries = Analysis CodeGen Core MC Support Target TransformUtils<br>
> +required_libraries = Analysis CodeGen Core MC SelectionDAG Support Target TransformUtils<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>