[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 13:10:49 PST 2016


qcolombet added inline comments.


================
Comment at: include/llvm/Target/TargetInstrInfo.h:821
+  /// Check whether the target can fold a load that feeds a subreg operand MO
+  /// (or a subreg operand MO that feeds a store).
+  /// This can be used to check the foldability of both loads and stores.
----------------
I am not sure I understand the intent. I believe this is just a problem of wording.
Basically, are you referring to this case:
v1 = ld
= op v1.sub

or this case:
v1.sub = ld
= op v1.sub

I believe this is the former and adding the example would help :).


https://reviews.llvm.org/D26521





More information about the llvm-commits mailing list