[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

In https://reviews.llvm.org/D26521#594426, @RKSimon wrote:

> Is it worth adding the partial-fold test files to trunk with current codegen?


I think that's rather less useful when not using update_llc_test_checks, since you don't see the full diff anyway. And, as I wrote above, I think update_llc_test_checks really does more harm than good in this case.
But I can add it anyway with just the relevant checks if you want the diff to be more explicit. What do you think?



================
Comment at: lib/CodeGen/TargetInstrInfo.cpp:553
+    }
+  }
+
----------------
RKSimon wrote:
> Do we need an assert(MemSize && "Empty stack slot") here?
Sure, I'll add one.


https://reviews.llvm.org/D26521