[PATCH] D26516: [PDB] Add documentation for the PDB Stream

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 11:47:09 PST 2016


amccarth added a comment.

Is the header the only thing in the stream?  The word "header" suggests that there's something more after it, but this seems to describe only the header.



================
Comment at: docs/PDB/PdbStream.rst:54
+- **Age** - The number of times the PDB file has been written.  This can be used
+  along with ``Guid`` to match the PDB to its corresponding executable.
+  
----------------
So a brand new PDB has an Age of 1 not 0?


================
Comment at: docs/PDB/PdbStream.rst:69
+re-uses the existing guid if it is linking incrementally) and increments the Age
+field.
+
----------------
Did you close the parentheses too soon?  I assume you only increment the Age when updating a PDB.  Otherwise, you'd just be initializing the Age, right?


https://reviews.llvm.org/D26516





More information about the llvm-commits mailing list