[PATCH] D26577: [AVR] Add the pseudo instruction expansion pass
Krzysztof Parzyszek via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 14 08:58:19 PST 2016
kparzysz added inline comments.
================
Comment at: lib/Target/AVR/AVRExpandPseudoInsts.cpp:255
+
+ auto MIBLO = buildMI(MBB, MBBI, OpLo)
+ .addReg(DstLoReg, RegState::Define | getDeadRegState(DstIsDead))
----------------
kparzysz wrote:
> You can just use the actual opcode here (and below, for OpHi), since you are expanding a specific opcode.
This is really your call. If you think this is clear, you can keep it. I tried to delete this comment, but phabricator would hang when I did it.
https://reviews.llvm.org/D26577
More information about the llvm-commits
mailing list