[PATCH] D26437: Use -fno-unit-at-a-time and -funit-at-a-time

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 00:30:19 PST 2016


rampitec added a comment.

In https://reviews.llvm.org/D26437#593556, @jlebar wrote:

> However, if you add a convergent nop intrinsic to the body of any function that is marked with the convergent attribute, this will behave correctly even in the face of inlining.


That is a better solution, agree. Marking all functions as convergent seems to be an overkill to me, but I have created a discardable barrier intrinsic and used it directly in the sub_group_barrier implementation. As expected that helped conformance test to pass.

That said I believe that still makes sense to submit the current change just to connect options we already have defined to their intended functionality.


Repository:
  rL LLVM

https://reviews.llvm.org/D26437





More information about the llvm-commits mailing list