[PATCH] D26437: Use -fno-unit-at-a-time and -funit-at-a-time

[Stanislav Mekhanoshin via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D26437#593563, @tejohnson wrote:

> They should be correctly limited in the case of externally visible functions. Otherwise -O2 would be failing.  E.g. GlobalOpt that you mentioned earlier is only going to remove unreferenced functions that are local or otherwise discardable (linkonce, available_externally linkages types).
>  Do you have an example where one of these passes is doing the wrong thing?


I have checked and it looks like these optimizations limit themselves to externally visible objects, at least for the part I have checked. That is clearly not the case with convergence attribute removal. I can fix the issue with the attribute differently though.

Then it is still probably worth enabling use of these options, because we already have them and we already have functionality they have to perform. We just do not connect one to another.


Repository:
  rL LLVM

https://reviews.llvm.org/D26437