[PATCH] D26210: Define DbiStreamBuilder::addSectionContribs.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp:315
+    Entry.Size = Sec.SizeOfRawData;
+    Entry.Characteristics = Sec.Characteristics;
+  }
----------------
zturner wrote:
> I think you should try to fill out `Entry.ISect` and `Entry.IMod`.  The first one seems like it's probably just the index, so you could get it by iterating over using `llvm::enumerate()`.  Not sure how you will get the last one, but it seems important nonetheless.  What do you think?
I will fill `ISect` but probably not `IMod` in this patch because I don't understand the meaning of the field yet.


https://reviews.llvm.org/D26210