[PATCH] D26210: Define DbiStreamBuilder::addSectionContribs.

[Zachary Turner via llvm-commits]

zturner added inline comments.


================
Comment at: include/llvm/DebugInfo/PDB/Raw/DbiStreamBuilder.h:68
 
+  // A helper function to create Section Contributions from
+  // COFF input section headers.
----------------
This line looks like it wraps too soon.


================
Comment at: lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp:315
+    Entry.Size = Sec.SizeOfRawData;
+    Entry.Characteristics = Sec.Characteristics;
+  }
----------------
I think you should try to fill out `Entry.ISect` and `Entry.IMod`.  The first one seems like it's probably just the index, so you could get it by iterating over using `llvm::enumerate()`.  Not sure how you will get the last one, but it seems important nonetheless.  What do you think?


https://reviews.llvm.org/D26210