[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

[Simon Pilgrim via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D26521#592842, @mkuper wrote:

> In https://reviews.llvm.org/D26521#592717, @RKSimon wrote:
>
> > Nice! I have an outstanding poor codegen issue with the inability to split+fold scalarization cases, do you think we would be able to expand this patch in the future to handle those cases?
>
>
> I don't know the spill/reload code well enough to even tell if it's happening for similar reasons or not.
>  But CC me on the PR, I'll take a look.


PR30986



================
Comment at: test/CodeGen/X86/partial-fold.ll:1
+; RUN: llc -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s
+
----------------
mkuper wrote:
> RKSimon wrote:
> > Add i686 tests as well and regenerate with utils\update_llc_test_checks.py
> Sure, I'll add i686.
> I'd prefer not to use update_llc_test_checks here - there's a *lot* of push/pop noise because of forcing all the regs to be used.
That's fine - it might mean that you have to split this into 32/64 versions of the file as the existing inline asm will fail on i686


https://reviews.llvm.org/D26521