[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 07:42:53 PST 2016


mkuper added a comment.

In https://reviews.llvm.org/D26521#592717, @RKSimon wrote:

> Nice! I have an outstanding poor codegen issue with the inability to split+fold scalarization cases, do you think we would be able to expand this patch in the future to handle those cases?


I don't know the spill/reload code well enough to even tell if it's happening for similar reasons or not.
But CC me on the PR, I'll take a look.



================
Comment at: test/CodeGen/X86/partial-fold.ll:1
+; RUN: llc -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s
+
----------------
RKSimon wrote:
> Add i686 tests as well and regenerate with utils\update_llc_test_checks.py
Sure, I'll add i686.
I'd prefer not to use update_llc_test_checks here - there's a *lot* of push/pop noise because of forcing all the regs to be used.


https://reviews.llvm.org/D26521





More information about the llvm-commits mailing list