[PATCH] D26430: Bitcode: Change the BitcodeReader to use llvm::Error internally.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp:4362
     case BitstreamEntry::EndBlock:
-      return std::error_code();
+      return Error::success();
 
----------------
mehdi_amini wrote:
> Returning `Error::success` with a conversion to `Expected` seems to trigger an assertion.
It seems that what we want to do here is `return ""`, since we didn't encounter any errors but did not find an identification.


Repository:
  rL LLVM

https://reviews.llvm.org/D26430