[PATCH] D26430: Bitcode: Change the BitcodeReader to use llvm::Error internally.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 13:54:21 PST 2016


mehdi_amini added inline comments.


================
Comment at: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp:4362
     case BitstreamEntry::EndBlock:
-      return std::error_code();
+      return Error::success();
 
----------------
Returning `Error::success` with a conversion to `Expected` seems to trigger an assertion.


Repository:
  rL LLVM

https://reviews.llvm.org/D26430





More information about the llvm-commits mailing list