[PATCH] D26405: Add the ability to dump hex bytes with optional offsets and ASCII bytes.

Greg Clayton via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 13:01:30 PST 2016


clayborg removed rL LLVM as the repository for this revision.
clayborg updated this revision to Diff 77246.
clayborg added a comment.

Fixed all of the previous inline comments:

- moved unittest to right file
- added support for byte groups so we can display 4 bytes at a time with no spaces by default
- added '|' delimiters so the ASCII looks better when displayed and matches other clients
- fixed early exits from loops
- used ArrayRef<uint8_t> instead of void * and size_t.


https://reviews.llvm.org/D26405

Files:
  include/llvm/Support/Format.h
  include/llvm/Support/raw_ostream.h
  lib/Support/raw_ostream.cpp
  unittests/Support/raw_ostream_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26405.77246.patch
Type: text/x-patch
Size: 13702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161108/ff197c43/attachment.bin>


More information about the llvm-commits mailing list