[PATCH] D26405: Add the ability to dump hex bytes with optional offsets and ASCII bytes.

[Zachary Turner via llvm-commits]

zturner added inline comments.


================
Comment at: include/llvm/Support/Format.h:223
+
+inline FormattedHexBytes format_hex_bytes(const void *P, size_t N,
+                                          uint64_t Offset = -1ULL,
----------------
mehdi_amini wrote:
> I'm not against the "type erasure" with `void *`, but what about also keeping an overload with an ArrayRef of uint8_t? It could avoid to have to unpack at call sites.
I kind of am.  Is there a reason why we need to specify `void* P, size_t N` when we can just specify `ArrayRef<uint8_t>`?


Repository:
  rL LLVM

https://reviews.llvm.org/D26405