[PATCH] D26374: Add documentation for the PDB file format

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 10:02:15 PST 2016


amccarth added inline comments.


================
Comment at: docs/PDB/MsfFile.rst:55
+  be stitched together accordingly.  The number of ``ulittle32_t``'s in this array
+  is given by ``⌈NumDirectoryBytes / BlockSize⌉``.
+  
----------------
zturner wrote:
> amccarth wrote:
> > Did you mean ``[NumDirectoryBytes / 4]``?
> No, this is correct.  For starters, that's intentionally a mathematical ceiling operator and not a square bracket :)  That aside though, Suppose your directory is magically exactly 4KiB and your block size is also 4KiB.  Then your directory fits on a single block, and thus you only need a single `ulittle32` to describe the list of blocks that it lies on.
Ah, got it.  Thanks for the clarification.

The ceiling operators in monospace font are really hard to distinguish from square brackets.  Given that we don't have full TeX capabilities, maybe it would be better to make it more code-like:  `ceil(NumDirectoryBytes / BlockSize)`.


https://reviews.llvm.org/D26374





More information about the llvm-commits mailing list