[PATCH] D26374: Add documentation for the PDB file format

[Zachary Turner via llvm-commits]

Nice find though, btw
On Tue, Nov 8, 2016 at 9:12 AM Zachary Turner <zturner at google.com> wrote:

> If my math is correct, you would need at least a 4GiB pdb before you would
> need a second directory block.
>
> It seems reasonable to have the documentation mention just the one field
> for now until I have a chance to research this some more and possibly
> implement large pdb support in llvm
> On Tue, Nov 8, 2016 at 9:00 AM David Majnemer <david.majnemer at gmail.com>
> wrote:
>
> majnemer added inline comments.
>
>
> ================
> Comment at: docs/PDB/MsfFile.rst:24
> +    ulittle32_t Unknown;
> +    ulittle32_t BlockMapAddr;
> +  };
> ----------------
> zturner wrote:
> > majnemer wrote:
> > > Looking at the microsoft-pdb sources, isn't this technically an array
> of addresses?
> > >
> https://github.com/Microsoft/microsoft-pdb/blob/master/PDB/msf/msf.cpp#L954
> > It's more like a pointer to an array.  It's a single uint32 which is the
> index of a block, and at that block is an array.
> My reading of the PDB sources makes me thing that its an array of pointers
> to arrays. I don't think we ever encountered this in the wild because our
> PDBs were not large enough.
>
>
> https://reviews.llvm.org/D26374
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161108/84e67a2c/attachment.html>