[PATCH] D25325: [ELF] Change way we place non-scripted (orphan) sections

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 06:50:22 PST 2016


Rafael, please take a look at orphan.s test case. To my understanding
orphan .jcr is a relro section and
should be put in the beginning of RW section list. Your patch places
it somewhere in the middle.
The NOBITS sections are placed correctly by both mine and your versions.

I don't know if this relro section issue is serious, but I would still
respect sort order.

2016-11-07 17:47 GMT+03:00 Eugene Leviant <evgeny.leviant at gmail.com>:
> evgeny777 updated this revision to Diff 77031.
> evgeny777 added a comment.
>
> Rebased +  modified test case orphan.s
>
>
> https://reviews.llvm.org/D25325
>
> Files:
>   ELF/Writer.cpp
>   test/ELF/linkerscript/orphan.s
>   test/ELF/linkerscript/sections-constraint.s
>


More information about the llvm-commits mailing list