[PATCH] D25858: [tsan][llvm] Implement the function attribute to disable TSan checking at run time

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 20:07:00 PST 2016


dvyukov added inline comments.


================
Comment at: lib/Transforms/Instrumentation/ThreadSanitizer.cpp:458
 
+  if (F.hasFnAttribute("sanitize_thread_no_checking_at_run_time")) {
+    assert(!F.hasFnAttribute(Attribute::SanitizeThread));
----------------
What are the chances that these functions don't contain any function calls?
If the chances are considerable, then I would prefix this on "Res || HasCalls" because there is nothing to ignore otherwise.


https://reviews.llvm.org/D25858





More information about the llvm-commits mailing list