[PATCH] D25859: [tsan] Expose __tsan_ignore_thread_begin and __tsan_ignore_thread_end in TSan interface

[Anna Zaks via llvm-commits]

zaks.anna added inline comments.


================
Comment at: test/tsan/Darwin/release-dealloc-norace-objcpp.mm:28
+  pthread_threadid_np(NULL, &tid);
+  [self accessMember];
+  printf("Dealloc from thread with id : %p \n", (void *)tid);
----------------
dvyukov wrote:
> I don't understand ordering of the patches.
> This patch is required for the tsan pass patch.
> But this test will only pass if the tsan pass patch is submitted.
> I think you need to split this patch into 2 parts: one adds the interface functions, another adds tests. Otherwise tree will be broken at some point.
You are correct. I'll split the patch into 2 before committing.


https://reviews.llvm.org/D25859