[PATCH] D26212: IRMover: Avoid accidentally mapping types from the destination module (PR30799)

Bob Haarman via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 15:23:01 PDT 2016


inglorion added a comment.

Thanks for updating the comment, @hans. I'll give @mehdi_amini some time to look into getIdentifiedStructTypes() and whether or not it is supposed to be this way. For what it's worth, my first instinct was that it shouldn't give us the types that this diff skips over, but after a cursory glance at the implementation (since there is no documentation), I concluded that this is ok. There may be a follow-up diff in our future to clarify the intended behavior of getIdentifiedStructTypes()...


https://reviews.llvm.org/D26212





More information about the llvm-commits mailing list