[PATCH] D26212: IRMover: Avoid accidentally mapping types from the destination module (PR30799)

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.



>> getIdentifiedStructTypes() isn't even documented in the Module header unfortunately. It is not clear off-hand it the issue should be handled in the IRMover or in `getIdentifiedStructTypes` itself.
> 
> I'm not sure how we'd change getIdentifiedStructTypes() though. Once we've ODR'd the metadata, the module now refers to a value with this type, and it makes sense that getIdentifiedStructTypes() finds it.

To begin with: in what situation walking the metadata graph can find a named typed that can't be found by walking only the IR?


https://reviews.llvm.org/D26212