[PATCH] D26199: [ELF] - Implemented --build-id=tree

[Rui Ueyama via llvm-commits]

On Tue, Nov 1, 2016 at 12:04 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> It might be better to have a distinct --threaded-hash option so that
> just enabling threads doesn't change the output, but I agree that we
> should add one option and have the existing implementations take it
> into consideration.
>

That's good point, we should generate the same hash with/without threads.
But we don't need a new option for that -- just compute a tree hash even if
threading is disabled.


> Cheers,
> Rafael
>
>
> On 1 November 2016 at 13:22, Rui Ueyama <ruiu at google.com> wrote:
> > ruiu added a comment.
> >
> > I don't think we want to add one more different type of --build-id=
> option because we already have too many. We probably should use threads by
> default for "fast", "sha1" and "md5".
> >
> >
> > https://reviews.llvm.org/D26199
> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161101/e7f234f5/attachment.html>