[PATCH] D26129: Implementation of expandload and compressstore intrinsics.

[Elena Demikhovsky via llvm-commits]

delena marked 2 inline comments as done.
delena added inline comments.


================
Comment at: ../lib/IR/Function.cpp:1086
+              dyn_cast<VectorType> (ArgTys[D.getArgumentNumber()]);
+      PointerType *ThisArgType = dyn_cast<PointerType>(Ty);
+
----------------
ABataev wrote:
> `auto *ThisArgType`
I'll align the code. 


================
Comment at: ../test/CodeGen/X86/compress_expand.ll:5-8
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+
----------------
ABataev wrote:
> Do you really need these lines?
Yes, on Windows %rdi will be replaced with %rcx, and some other patterns may fail on mac. We always define triple.


Repository:
  rL LLVM

https://reviews.llvm.org/D26129