[PATCH] D26129: Implementation of expandload and compressstore intrinsics.

[Alexey Bataev via llvm-commits]

ABataev added inline comments.


================
Comment at: ../lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3698
+void SelectionDAGBuilder::visitMaskedCompressStore(const CallInst &I) {
+  SDLoc sdl = getCurSDLoc();
+
----------------
sdl->Sdl


================
Comment at: ../lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3859
+void SelectionDAGBuilder::visitMaskedExpandLoad(const CallInst &I) {
+  SDLoc sdl = getCurSDLoc();
+
----------------
sdl->Sdl


================
Comment at: ../lib/IR/Function.cpp:1084
+        return true;
+      VectorType * ReferenceType =
+              dyn_cast<VectorType> (ArgTys[D.getArgumentNumber()]);
----------------
`auto *ReferenceType`, and this line seems not formatted properly


================
Comment at: ../lib/IR/Function.cpp:1086
+              dyn_cast<VectorType> (ArgTys[D.getArgumentNumber()]);
+      PointerType *ThisArgType = dyn_cast<PointerType>(Ty);
+
----------------
`auto *ThisArgType`


================
Comment at: ../test/CodeGen/X86/compress_expand.ll:5-8
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+
----------------
Do you really need these lines?


Repository:
  rL LLVM

https://reviews.llvm.org/D26129