[PATCH] D25891: [llvm] Convert iterable SmallPtrSet's to SmallSetVector's in Codegen

[David Blaikie via llvm-commits]

On Tue, Oct 25, 2016 at 12:38 PM Mandeep Singh Grang via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> mgrang added a comment.
>
> Yes, this is an attempt to preempt potential non-determinism caused due to
> iteration of unordered sets.
>
> If this seems too aggressive then we can take the approach of identifying
> the exact causes and fixing just those.
>

Yeah, I don't think it would be practical to remove the ability to iterate
over unstable iteration order containers in LLVM.

(re: Reid's suggestion - we could, under NDEBUG (+ maybe some other flag to
engage this), simply iterate in reverse order in any unstably ordered
containers - or something along those lines)


>
> Let me spin-off a few test runs on our internal test suite and I will come
> back with new fix/fixes.
>
> Thanks,
> Mandeep
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D25891
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161031/1667504f/attachment.html>