<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 25, 2016 at 12:38 PM Mandeep Singh Grang via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">mgrang added a comment.<br class="gmail_msg">
<br class="gmail_msg">
Yes, this is an attempt to preempt potential non-determinism caused due to iteration of unordered sets.<br class="gmail_msg">
<br class="gmail_msg">
If this seems too aggressive then we can take the approach of identifying the exact causes and fixing just those.<br class="gmail_msg"></blockquote><div><br>Yeah, I don't think it would be practical to remove the ability to iterate over unstable iteration order containers in LLVM.<br><br>(re: Reid's suggestion - we could, under NDEBUG (+ maybe some other flag to engage this), simply iterate in reverse order in any unstably ordered containers - or something along those lines)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
Let me spin-off a few test runs on our internal test suite and I will come back with new fix/fixes.<br class="gmail_msg">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
Mandeep<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D25891" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25891</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>