[PATCH] D26144: DebugInfo: make DW_TAG_atomic_type valid

[Victor Leschuk via llvm-commits]

vleschuk marked an inline comment as done.
vleschuk added inline comments.


================
Comment at: test/DebugInfo/X86/atomic_c11.ll:11
+; CHECK: DW_TAG_const_type
+; CHECK: DW_TAG_atomic_type
+
----------------
aprantl wrote:
> Please check for the entire type tree: otherwise output like (hypothetical example)
> 
> `error: unknown token: DW_TAG_atomic_type`
> 
> would match, too.
WIll do.


================
Comment at: test/DebugInfo/X86/atomic_c11.ll:16
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
aprantl wrote:
> Could you include a comment with the source this was generated from?
It's included, see lines 4-7:

```
; Generated by clang -c -g -std=c11 -S -emit-llvm from the following C11 source
;
; _Atomic const int i;
;
```



https://reviews.llvm.org/D26144