[PATCH] D26144: DebugInfo: make DW_TAG_atomic_type valid

[Adrian Prantl via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/CodeView/CodeView.h:284
+  Unaligned = 0x0004,
+  Atomic = 0x0008
 };
----------------
Can someone familiar with the CodeView code check this?


================
Comment at: test/DebugInfo/X86/atomic_c11.ll:11
+; CHECK: DW_TAG_const_type
+; CHECK: DW_TAG_atomic_type
+
----------------
Please check for the entire type tree: otherwise output like (hypothetical example)

`error: unknown token: DW_TAG_atomic_type`

would match, too.


================
Comment at: test/DebugInfo/X86/atomic_c11.ll:16
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
Could you include a comment with the source this was generated from?


================
Comment at: test/DebugInfo/X86/atomic_c11.ll:30
+!5 = !DIFile(filename: "atomic.c", directory: "/tmp")
+!6 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !7)
+!7 = !DIDerivedType(tag: DW_TAG_atomic_type, baseType: !8)
----------------
This seems unnecessary for the test?


https://reviews.llvm.org/D26144