[PATCH] D26094: Handle non-~0 lane masks on live-in registers in LivePhysRegs

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 12:48:32 PDT 2016


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/CodeGen/LivePhysRegs.cpp:151-154
+    while (S.isValid()) {
       if (LI.LaneMask & TRI->getSubRegIndexLaneMask(S.getSubRegIndex()))
         addReg(S.getSubReg());
+      ++S;
----------------
change this to a `for ( ; S.isValid(); ++S) { ... }` loop?


Repository:
  rL LLVM

https://reviews.llvm.org/D26094





More information about the llvm-commits mailing list