[llvm] r285429 - [x86] add tests for missed umin/umax

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 12:08:21 PDT 2016


Author: spatel
Date: Fri Oct 28 14:08:20 2016
New Revision: 285429

URL: http://llvm.org/viewvc/llvm-project?rev=285429&view=rev
Log:
[x86] add tests for missed umin/umax

This is actually a deficiency in ValueTracking's matchSelectPattern(),
but a codegen test is the simplest way to expose the bug.

Added:
    llvm/trunk/test/CodeGen/X86/vec_umin_umax.ll

Added: llvm/trunk/test/CodeGen/X86/vec_umin_umax.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/vec_umin_umax.ll?rev=285429&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/vec_umin_umax.ll (added)
+++ llvm/trunk/test/CodeGen/X86/vec_umin_umax.ll Fri Oct 28 14:08:20 2016
@@ -0,0 +1,59 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx | FileCheck %s
+
+; FIXME: These are unsigned min/max ops.
+
+define <4 x i32> @umax_vec1(<4 x i32> %x) {
+; CHECK-LABEL: umax_vec1:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    vpxor %xmm1, %xmm1, %xmm1
+; CHECK-NEXT:    vpcmpgtd %xmm0, %xmm1, %xmm1
+; CHECK-NEXT:    vmovaps {{.*#+}} xmm2 = [2147483647,2147483647,2147483647,2147483647]
+; CHECK-NEXT:    vblendvps %xmm1, %xmm0, %xmm2, %xmm0
+; CHECK-NEXT:    retq
+;
+  %cmp = icmp slt <4 x i32> %x, zeroinitializer
+  %sel = select <4 x i1> %cmp, <4 x i32> %x, <4 x i32> <i32 2147483647, i32 2147483647, i32 2147483647, i32 2147483647>
+  ret <4 x i32> %sel
+}
+
+define <4 x i32> @umax_vec2(<4 x i32> %x) {
+; CHECK-LABEL: umax_vec2:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    vpcmpeqd %xmm1, %xmm1, %xmm1
+; CHECK-NEXT:    vpcmpgtd %xmm1, %xmm0, %xmm1
+; CHECK-NEXT:    vblendvps %xmm1, {{.*}}(%rip), %xmm0, %xmm0
+; CHECK-NEXT:    retq
+;
+  %cmp = icmp sgt <4 x i32> %x, <i32 -1, i32 -1, i32 -1, i32 -1>
+  %sel = select <4 x i1> %cmp, <4 x i32> <i32 2147483648, i32 2147483648, i32 2147483648, i32 2147483648>, <4 x i32> %x
+  ret <4 x i32> %sel
+}
+
+define <4 x i32> @umin_vec1(<4 x i32> %x) {
+; CHECK-LABEL: umin_vec1:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    vpxor %xmm1, %xmm1, %xmm1
+; CHECK-NEXT:    vpcmpgtd %xmm0, %xmm1, %xmm1
+; CHECK-NEXT:    vblendvps %xmm1, {{.*}}(%rip), %xmm0, %xmm0
+; CHECK-NEXT:    retq
+;
+  %cmp = icmp slt <4 x i32> %x, zeroinitializer
+  %sel = select <4 x i1> %cmp, <4 x i32> <i32 2147483647, i32 2147483647, i32 2147483647, i32 2147483647>, <4 x i32> %x
+  ret <4 x i32> %sel
+}
+
+define <4 x i32> @umin_vec2(<4 x i32> %x) {
+; CHECK-LABEL: umin_vec2:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    vpcmpeqd %xmm1, %xmm1, %xmm1
+; CHECK-NEXT:    vpcmpgtd %xmm1, %xmm0, %xmm1
+; CHECK-NEXT:    vmovaps {{.*#+}} xmm2 = [2147483648,2147483648,2147483648,2147483648]
+; CHECK-NEXT:    vblendvps %xmm1, %xmm0, %xmm2, %xmm0
+; CHECK-NEXT:    retq
+;
+  %cmp = icmp sgt <4 x i32> %x, <i32 -1, i32 -1, i32 -1, i32 -1>
+  %sel = select <4 x i1> %cmp, <4 x i32> %x, <4 x i32> <i32 2147483648, i32 2147483648, i32 2147483648, i32 2147483648>
+  ret <4 x i32> %sel
+}
+




More information about the llvm-commits mailing list