[PATCH] D26063: [ThinLTO] Use NoPromote flag in summary during promotion

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/Transforms/Utils/FunctionImportUtils.h:58
   /// a local that is being promoted to global scope.
-  std::string getName(const GlobalValue *SGV);
+  std::string getName(const GlobalValue *SGV, bool DoPromote);
 
----------------
Update doc.


================
Comment at: include/llvm/Transforms/Utils/FunctionImportUtils.h:70
   /// to be adjusted.
-  GlobalValue::LinkageTypes getLinkage(const GlobalValue *SGV);
+  GlobalValue::LinkageTypes getLinkage(const GlobalValue *SGV, bool DoPromote);
 
----------------
Ditto.


================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:206
   } else
-    GV.setLinkage(getLinkage(&GV));
+    GV.setLinkage(getLinkage(&GV, DoPromote));
 
----------------
The flow to initialize the "DoPromote" is very difficult to process / follow here. We should seek some refactoring to make it more readable.


https://reviews.llvm.org/D26063