[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/InputFiles.cpp:65
+  // The offset to CU is 0 (see DIHelper constructor).
+  const DWARFDebugLine::LineTable *LineTbl = DwarfLine->getLineTable(0);
+  if (!LineTbl)
----------------
rafael wrote:
> Can you move the call to getLineTable to the constructor and cache LineTbl?
Yes, it's possible to make LineTbl a member variable (together with DwarfLine), but getLineTable(Offset) is actually very fast. It's a single lookup in std::map with one element.


https://reviews.llvm.org/D25826