[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 25 05:35:03 PDT 2016
rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.
This is awesome.
Fine by me with a nit, but please wait for Rui to LGTM too.
================
Comment at: ELF/InputFiles.cpp:65
+ // The offset to CU is 0 (see DIHelper constructor).
+ const DWARFDebugLine::LineTable *LineTbl = DwarfLine->getLineTable(0);
+ if (!LineTbl)
----------------
Can you move the call to getLineTable to the constructor and cache LineTbl?
https://reviews.llvm.org/D25826
More information about the llvm-commits
mailing list