[lld] r284878 - Compact SymbolBody from 56 to 48 bytes.

[Rui Ueyama via llvm-commits]

On Fri, Oct 21, 2016 at 1:32 PM, Rafael Espindola via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: rafael
> Date: Fri Oct 21 15:32:41 2016
> New Revision: 284878
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284878&view=rev
> Log:
> Compact SymbolBody from 56 to 48 bytes.
>
> Modified:
>     lld/trunk/ELF/Symbols.h
>
> Modified: lld/trunk/ELF/Symbols.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.
> h?rev=284878&r1=284877&r2=284878&view=diff
> ============================================================
> ==================
> --- lld/trunk/ELF/Symbols.h (original)
> +++ lld/trunk/ELF/Symbols.h Fri Oct 21 15:32:41 2016
> @@ -79,11 +79,6 @@ public:
>
>    uint8_t getVisibility() const { return StOther & 0x3; }
>
> -  unsigned DynsymIndex = 0;
> -  uint32_t GotIndex = -1;
> -  uint32_t GotPltIndex = -1;
> -  uint32_t PltIndex = -1;
> -  uint32_t GlobalDynIndex = -1;
>    bool isInGot() const { return GotIndex != -1U; }
>    bool isInPlt() const { return PltIndex != -1U; }
>    template <class ELFT> bool hasThunk() const;
> @@ -102,6 +97,12 @@ public:
>    // The file from which this symbol was created.
>    InputFile *File = nullptr;
>
> +  unsigned DynsymIndex = 0;
> +  uint32_t GotIndex = -1;
> +  uint32_t GotPltIndex = -1;
> +  uint32_t PltIndex = -1;
> +  uint32_t GlobalDynIndex = -1;
>

I wonder if we can use uint32_t for DynsymIndex just like for other
variables.


>    protected:
>    SymbolBody(Kind K, StringRef Name, uint8_t StOther, uint8_t Type);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161021/a7be368b/attachment.html>