<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Oct 21, 2016 at 1:32 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Fri Oct 21 15:32:41 2016<br>
New Revision: 284878<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284878&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=284878&view=rev</a><br>
Log:<br>
Compact SymbolBody from 56 to 48 bytes.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Symbols.h<br>
<br>
Modified: lld/trunk/ELF/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=284878&r1=284877&r2=284878&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/Symbols.<wbr>h?rev=284878&r1=284877&r2=<wbr>284878&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Symbols.h (original)<br>
+++ lld/trunk/ELF/Symbols.h Fri Oct 21 15:32:41 2016<br>
@@ -79,11 +79,6 @@ public:<br>
<br>
   uint8_t getVisibility() const { return StOther & 0x3; }<br>
<br>
-  unsigned DynsymIndex = 0;<br>
-  uint32_t GotIndex = -1;<br>
-  uint32_t GotPltIndex = -1;<br>
-  uint32_t PltIndex = -1;<br>
-  uint32_t GlobalDynIndex = -1;<br>
   bool isInGot() const { return GotIndex != -1U; }<br>
   bool isInPlt() const { return PltIndex != -1U; }<br>
   template <class ELFT> bool hasThunk() const;<br>
@@ -102,6 +97,12 @@ public:<br>
   // The file from which this symbol was created.<br>
   InputFile *File = nullptr;<br>
<br>
+  unsigned DynsymIndex = 0;<br>
+  uint32_t GotIndex = -1;<br>
+  uint32_t GotPltIndex = -1;<br>
+  uint32_t PltIndex = -1;<br>
+  uint32_t GlobalDynIndex = -1;<br></blockquote><div><br></div><div>I wonder if we can use uint32_t for DynsymIndex just like for other variables.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">   protected:<br>
   SymbolBody(Kind K, StringRef Name, uint8_t StOther, uint8_t Type);<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>