[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:569-571
+    warn(Location, Msg);
   else
+    error(Location, Msg);
----------------
evgeny777 wrote:
> ruiu wrote:
> > Now that you can just concatenate strings before passing to the functions.
> > 
> >   warn(Location + ": " + Msg);
> >   error(Location + ": " + Msg);
> > 
> > So I think you don't need to add new overloaded functions to error.cpp.
> Actually location and message are separated by message type, i.e:
> 
> ```
> <Location> : warning : <Msg>
> ```
Did you have a reason to break consistency that way here?


https://reviews.llvm.org/D25826