[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 13:46:46 PDT 2016


evgeny777 added inline comments.


================
Comment at: ELF/Relocations.cpp:569-571
+    warn(Location, Msg);
   else
+    error(Location, Msg);
----------------
ruiu wrote:
> Now that you can just concatenate strings before passing to the functions.
> 
>   warn(Location + ": " + Msg);
>   error(Location + ": " + Msg);
> 
> So I think you don't need to add new overloaded functions to error.cpp.
Actually location and message are separated by message type, i.e:

```
<Location> : warning : <Msg>
```


https://reviews.llvm.org/D25826





More information about the llvm-commits mailing list