[PATCH] D25833: [ELF][MIPS] Put local GOT entries accessed via a 16-bit index first

Mandeep Singh Grang via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 13:13:13 PDT 2016


mgrang added inline comments.


================
Comment at: ELF/OutputSections.cpp:205
     Sym.IsInGlobalMipsGot = true;
+  } else if (Expr == R_MIPS_GOT_OFF32) {
+    AddEntry(Sym, Addend, MipsLocal32);
----------------
atanasyan wrote:
> mgrang wrote:
> > Fix indentation. It would be great if you could fix indentation of the next "else" too :)
> > Fix indentation. It would be great if you could fix indentation of the next "else" too
> 
> I'm sorry, but what is wrong with the current indentation? Brackets are on the same line with the `else if` statement, the code block is indented by two spaces.
I thought the statements must be indented two spaces under the else-if too. But now that I see, it seems fine having the statements align with those under the preceding "if".


Repository:
  rL LLVM

https://reviews.llvm.org/D25833





More information about the llvm-commits mailing list