[PATCH] D25833: [ELF][MIPS] Put local GOT entries accessed via a 16-bit index first

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 11:49:40 PDT 2016


atanasyan added inline comments.


================
Comment at: ELF/OutputSections.cpp:205
     Sym.IsInGlobalMipsGot = true;
+  } else if (Expr == R_MIPS_GOT_OFF32) {
+    AddEntry(Sym, Addend, MipsLocal32);
----------------
mgrang wrote:
> Fix indentation. It would be great if you could fix indentation of the next "else" too :)
> Fix indentation. It would be great if you could fix indentation of the next "else" too

I'm sorry, but what is wrong with the current indentation? Brackets are on the same line with the `else if` statement, the code block is indented by two spaces.


Repository:
  rL LLVM

https://reviews.llvm.org/D25833





More information about the llvm-commits mailing list