[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 08:13:13 PDT 2016


evgeny777 added inline comments.


================
Comment at: ELF/Relocations.cpp:543
+  return (SrcFile + " (" + S.Name + "+0x" + Twine::utohexstr(Offset) + ")")
+      .str();
+}
----------------
grimar wrote:
> Looks you do not need .str() here.
Yes, I do. The type of expression is llvm::Twine because of S.Name and Twine::utohexstr(Offset)


https://reviews.llvm.org/D25826





More information about the llvm-commits mailing list